Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1 release compatibility #341

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

mdupras
Copy link
Contributor

@mdupras mdupras commented Oct 19, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I need a fix in the 3.1 releases, sadly the alpha version of the .Web isn't compatible with the 3.1 release yet. I created this branch to fix the using in the .Web package.

  • Added Feedz.io source for alpha builds
  • Updated some using to work with 3.1 releases

Updated some using to work with 3.1 releases
NuGet.Config Outdated
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn’t be required. The feed details are inherited in a props file via the shared infrastructure sub module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh good to know, removed it

@JimBobSquarePants
Copy link
Member

Thanks for this. There’s build issues due to missing namespaces. Could you build this locally?

@mdupras
Copy link
Contributor Author

mdupras commented Oct 27, 2023

Thanks for this. There’s build issues due to missing namespaces. Could you build this locally?

Really weird, pretty sure it was building locally at some point. I justed fixed it.

image
I also have those changes, but I suspect its because I'm building on Linux, so I'm not including them in the PR.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #341 (7c49794) into main (60d19fb) will decrease coverage by 1%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #341   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        82     82           
  Lines      2334   2334           
  Branches    348    348           
===================================
- Hits       1998   1996    -2     
- Misses      233    235    +2     
  Partials    103    103           
Flag Coverage Δ
unittests 85% <100%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ImageSharp.Web/ExifOrientationUtilities.cs 89% <ø> (ø)
src/ImageSharp.Web/FormattedImage.cs 82% <100%> (ø)
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 83% <ø> (ø)
...mageSharp.Web/Processors/AutoOrientWebProcessor.cs 85% <ø> (ø)
...harp.Web/Processors/BackgroundColorWebProcessor.cs 100% <ø> (ø)
...c/ImageSharp.Web/Processors/QualityWebProcessor.cs 97% <100%> (ø)
...rc/ImageSharp.Web/Processors/ResizeWebProcessor.cs 89% <ø> (ø)
src/ImageSharp.Web/Resampler.cs 100% <ø> (ø)
src/ImageSharp.Web/TagHelpers/ImageTagHelper.cs 91% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍Thanks!

@JimBobSquarePants JimBobSquarePants merged commit 2ac2e3c into SixLabors:main Nov 6, 2023
8 of 9 checks passed
renovate bot referenced this pull request in orso-co/Orso.Arpa.Api Dec 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[SixLabors.ImageSharp.Web](https://togithub.com/SixLabors/ImageSharp.Web)
| `3.0.1` -> `3.1.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/SixLabors.ImageSharp.Web/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/SixLabors.ImageSharp.Web/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/SixLabors.ImageSharp.Web/3.0.1/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/SixLabors.ImageSharp.Web/3.0.1/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SixLabors/ImageSharp.Web (SixLabors.ImageSharp.Web)</summary>

###
[`v3.1.0`](https://togithub.com/SixLabors/ImageSharp.Web/releases/tag/v3.1.0)

#### What's Changed

- Remove async HMAC operations. by
[@&#8203;JimBobSquarePants](https://togithub.com/JimBobSquarePants) in
[https://github.com/SixLabors/ImageSharp.Web/pull/327](https://togithub.com/SixLabors/ImageSharp.Web/pull/327)
- Use HMAC one-shot methods instead of instances by
[@&#8203;jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) in
[https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330)
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/SixLabors/ImageSharp.Web/pull/336](https://togithub.com/SixLabors/ImageSharp.Web/pull/336)
- 3.1 release compatibility by
[@&#8203;mdupras](https://togithub.com/mdupras) in
[https://github.com/SixLabors/ImageSharp.Web/pull/341](https://togithub.com/SixLabors/ImageSharp.Web/pull/341)
- Update Imagesharp by
[@&#8203;JimBobSquarePants](https://togithub.com/JimBobSquarePants) in
[https://github.com/SixLabors/ImageSharp.Web/pull/345](https://togithub.com/SixLabors/ImageSharp.Web/pull/345)

#### New Contributors

- [@&#8203;jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) made
their first contribution in
[https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330)

**Full Changelog**:
SixLabors/ImageSharp.Web@v3.0.1...v3.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in orso-co/Orso.Arpa.Api Dec 9, 2023
…845)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[SixLabors.ImageSharp.Web.Providers.Azure](https://togithub.com/SixLabors/ImageSharp.Web)
| `3.0.1` -> `3.1.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/SixLabors.ImageSharp.Web.Providers.Azure/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/SixLabors.ImageSharp.Web.Providers.Azure/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/SixLabors.ImageSharp.Web.Providers.Azure/3.0.1/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/SixLabors.ImageSharp.Web.Providers.Azure/3.0.1/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SixLabors/ImageSharp.Web
(SixLabors.ImageSharp.Web.Providers.Azure)</summary>

###
[`v3.1.0`](https://togithub.com/SixLabors/ImageSharp.Web/releases/tag/v3.1.0)

#### What's Changed

- Remove async HMAC operations. by
[@&#8203;JimBobSquarePants](https://togithub.com/JimBobSquarePants) in
[https://github.com/SixLabors/ImageSharp.Web/pull/327](https://togithub.com/SixLabors/ImageSharp.Web/pull/327)
- Use HMAC one-shot methods instead of instances by
[@&#8203;jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) in
[https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330)
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/SixLabors/ImageSharp.Web/pull/336](https://togithub.com/SixLabors/ImageSharp.Web/pull/336)
- 3.1 release compatibility by
[@&#8203;mdupras](https://togithub.com/mdupras) in
[https://github.com/SixLabors/ImageSharp.Web/pull/341](https://togithub.com/SixLabors/ImageSharp.Web/pull/341)
- Update Imagesharp by
[@&#8203;JimBobSquarePants](https://togithub.com/JimBobSquarePants) in
[https://github.com/SixLabors/ImageSharp.Web/pull/345](https://togithub.com/SixLabors/ImageSharp.Web/pull/345)

#### New Contributors

- [@&#8203;jevgenigeurtsen](https://togithub.com/jevgenigeurtsen) made
their first contribution in
[https://github.com/SixLabors/ImageSharp.Web/pull/330](https://togithub.com/SixLabors/ImageSharp.Web/pull/330)

**Full Changelog**:
SixLabors/ImageSharp.Web@v3.0.1...v3.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants